Skip to content

Fix: Fixed issue where the Customize tab was shown for folders that don't support custom icons#18762

Open
workbysaran wants to merge 1 commit into
files-community:mainfrom
workbysaran:sg/fix-customize-tab-unsupported-folders
Open

Fix: Fixed issue where the Customize tab was shown for folders that don't support custom icons#18762
workbysaran wants to merge 1 commit into
files-community:mainfrom
workbysaran:sg/fix-customize-tab-unsupported-folders

Conversation

@workbysaran

Copy link
Copy Markdown
Contributor

Resolved / Related Issues

Closes #6689

Steps used to test these changes

  1. Opened Files, navigated to a UNC network share (\server\share\folder), right-clicked a subfolder > Properties > confirmed the Customize tab no longer appears.
  2. Opened Properties on a local folder (e.g. under C:) > confirmed the Customize tab still appears and setting a custom icon still works.

@CLAassistant

CLAassistant commented Jul 22, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we already have a helper for detecting network paths, can you check if it can be reused?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked. The only thing close is ShellViewModel.IsNetworkFolder, but that just compares against the Shell:NetworkPlacesFolder root, so it doesn't cover UNC paths or mapped network drives. I also noticed GetRootFromPathAsync is checking network path, but if needed I can refactor it.

@yair100
yair100 requested a review from Josh65-2201 July 22, 2026 13:57
@yair100 yair100 added the ready for review Pull requests that are ready for review label Jul 22, 2026

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folders in network drives/shares can have the folder icons customized. The only place it should be disabled is the root for device shares \\127.0.0.1 or mapped drive

Image

@workbysaran

Copy link
Copy Markdown
Contributor Author

@Josh65-2201
What you're showing is Folder pictures, a legacy Windows XP feature that doesn't work consistently, and we don't implement it anyway, The Folder icon isn't offered for network folders in native Explorer (see the pic below), root or not, so disabling Customize for all network paths matches Explorer's own behaviour, not just at the root. The original behaviour is correct and I don't think we should narrow it to root-only.
image

@workbysaran
workbysaran requested a review from Josh65-2201 July 23, 2026 08:33

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I haven't used Windows File Explorer for setting the icon for a long time.
In that case the only reason it wouldn't work is if the group policy allow remove paths for icons isn't enabled. I have use Files to set folder icons fine on network so maybe a settings or if possible detecting that group policy could be done even if it isn't in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Customize page is shown for network folder that don't support changing it

4 participants