Fix: Fixed issue where the Customize tab was shown for folders that don't support custom icons#18762
Conversation
…on't support custom icons
There was a problem hiding this comment.
I'm pretty sure we already have a helper for detecting network paths, can you check if it can be reused?
There was a problem hiding this comment.
I checked. The only thing close is ShellViewModel.IsNetworkFolder, but that just compares against the Shell:NetworkPlacesFolder root, so it doesn't cover UNC paths or mapped network drives. I also noticed GetRootFromPathAsync is checking network path, but if needed I can refactor it.
|
@Josh65-2201 |
There was a problem hiding this comment.
I see I haven't used Windows File Explorer for setting the icon for a long time.
In that case the only reason it wouldn't work is if the group policy allow remove paths for icons isn't enabled. I have use Files to set folder icons fine on network so maybe a settings or if possible detecting that group policy could be done even if it isn't in this PR


Resolved / Related Issues
Closes #6689
Steps used to test these changes