This repository was archived by the owner on Oct 12, 2026. It is now read-only.
Repository navigation
Syncing build info data structure with logdetective - #36
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the BuildMetadata model and updates the artifact handling logic to support both URLs and raw content. The call_log_detective function now constructs a more comprehensive analysis request including these new fields. Feedback focuses on ensuring optional Pydantic fields have explicit defaults for proper serialization, correcting a test expectation mismatch regarding URL keys, and fixing a typo in a docstring.
jpodivin
force-pushed
the
better_build_info
branch
from
April 17, 2026 09:15
de70635 to
66dd813
Compare
nforro
approved these changes
Apr 20, 2026
Jany26
approved these changes
Apr 20, 2026
Jany26
left a comment
Jany26
left a comment
Contributor
There was a problem hiding this comment.
Apart from Nikola's concern, LGTM.
Improving code snippet annotations Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
jpodivin
force-pushed
the
better_build_info
branch
from
April 20, 2026 07:48
66dd813 to
5fbfb00
Compare
centosinfra-prod-github-app Bot
added a commit
to packit/packit-service
that referenced
this pull request
Apr 20, 2026
Submit more files to Log Detective for analysis References to multiple artifacts are now used when asking Log Detective for analysis. Since we can not be completely sure about their availability, all URLs are checked using get request. If no artifacts pass the check, the trigger fails and the information is logged. In order to avoid references to files that can't be possibly analyzed by Log Detective, only URLs pointing to files of the text/plain type are allowed, all others are dropped from the final request. This check should see more use as we interact with other build backends, and submit artifacts other than just logs. New tests for the verify_artifact were introduced and existing tests adjusted. Merge after fedora-copr/logdetective-packit#36 fedora-copr/logdetective#492 RELEASE NOTES BEGIN Packit now sends build.log, root.log and mock_output.log from failed Koji builds to Log Detective. RELEASE NOTES END Reviewed-by: gemini-code-assist[bot] Reviewed-by: Nikola Forró Reviewed-by: Jiří Podivín Reviewed-by: Laura Barcziová
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduced with agentic Log Detective API must be reflected in the in how interface server packages information coming in from packit. The PR also contains changes to tests and improved formatting of code snippets in README.md
Related: fedora-copr/logdetective#492