Skip to content

fix: guard normalizeIP against undefined or non-string IP #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TalhaHunter101 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard normalizeIP against undefined or non-string IP #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ const draftSpecHeaders = {
const defaultOnFn = () => {}

function normalizeIP (ip, ipv6Subnet = defaultIPv6Subnet) {
if (typeof ip !== 'string') {
return ''
}

if (!isIPv6(ip)) {
return ip.toLowerCase()
}
Expand Down
22 changes: 21 additions & 1 deletion test/ip-normalization.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ function requestFrom (ip) {
}

test('normalizeIP canonicalizes IP address strings', (t) => {
t.plan(7)
t.plan(9)

t.assert.deepStrictEqual(normalizeIP(undefined), '')
t.assert.deepStrictEqual(normalizeIP(null), '')
t.assert.deepStrictEqual(normalizeIP('127.0.0.1'), '127.0.0.1')
t.assert.deepStrictEqual(normalizeIP('Example.COM'), 'example.com')
t.assert.deepStrictEqual(normalizeIP('::ffff:192.0.2.1'), '192.0.2.1')
Expand Down Expand Up @@ -89,3 +91,21 @@ test('invalid ipv6Subnet values fall back to /64', async (t) => {
res = await fastify.inject(requestFrom('2001:db8:abcd:13::1'))
t.assert.deepStrictEqual(res.statusCode, 200)
})

test('handles undefined req.ip gracefully without crashing', async (t) => {
t.plan(2)

const fastify = Fastify()
await fastify.register(rateLimit, { max: 2, timeWindow: 10000 })
fastify.get('/', async () => 'ok')
fastify.addHook('onRequest', async (req) => {
Object.defineProperty(req, 'ip', { get: () => undefined })
})
t.after(() => fastify.close())

const res1 = await fastify.inject({ method: 'GET', url: '/' })
t.assert.deepStrictEqual(res1.statusCode, 200)

const res2 = await fastify.inject({ method: 'GET', url: '/' })
t.assert.deepStrictEqual(res2.statusCode, 200)
})
Loading