Skip to content

test: fix flaky 'limit reset per Local storage' test #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonisetkowicz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: fix flaky 'limit reset per Local storage' test #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f78b37
test: fix flaky 'limit reset per Local storage' test
antonisetkowicz Jun 20, 2026
4e76ec7
Merge branch 'main' into fix/flaky-limit-reset-test
Tony133 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions test/route-rate-limit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,9 @@ test('variable max contenders', async (t) => {
}
})

// // TODO this test gets extremely flaky because of setTimeout
// // rewrite using https://www.npmjs.com/package/@sinonjs/fake-timers
test('limit reset per Local storage', { skip: true }, async (t) => {
t.plan(12)
test('limit reset per Local storage', async (t) => {
const clock = mock.timers
clock.enable(0)
const fastify = Fastify()
await fastify.register(rateLimit, { global: false })

Expand All @@ -717,19 +716,28 @@ test('limit reset per Local storage', { skip: true }, async (t) => {
}
)

setTimeout(doRequest.bind(null, 4), 0)
setTimeout(doRequest.bind(null, 3), 1000)
setTimeout(doRequest.bind(null, 2), 2000)
setTimeout(doRequest.bind(null, 1), 3000)
setTimeout(doRequest.bind(null, 0), 4000)
setTimeout(doRequest.bind(null, 4), 4100)
let res

function doRequest (resetValue) {
fastify.inject('/', (err, res) => {
t.error(err)
t.assert.deepStrictEqual(res.headers['x-ratelimit-reset'], resetValue)
})
}
res = await fastify.inject('/')
t.assert.deepStrictEqual(res.headers['x-ratelimit-reset'], '4')

clock.tick(1000)
res = await fastify.inject('/')
t.assert.deepStrictEqual(res.headers['x-ratelimit-reset'], '3')

clock.tick(1000)
res = await fastify.inject('/')
t.assert.deepStrictEqual(res.headers['x-ratelimit-reset'], '2')

clock.tick(1000)
res = await fastify.inject('/')
t.assert.deepStrictEqual(res.headers['x-ratelimit-reset'], '1')

clock.tick(1000)
res = await fastify.inject('/')
t.assert.deepStrictEqual(res.headers['x-ratelimit-reset'], '4')

clock.reset()
})

test('hide rate limit headers', async (t) => {
Expand Down
Loading