Skip to content

📝 Fix stale requirements.txt install command in the completion container guide #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HyperionBurn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

📝 Fix stale requirements.txt install command in the completion container guide #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ root@79c4b9b70cbe:/code#
Then inside the container, you can install `typer` with:

```console
$ uv pip install -r requirements.txt
$ uv pip install -e .
```

Then, you can start the shell you want to use, the one where you want to try out completion:
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ COPY . /code

WORKDIR /code

RUN uv pip install -r requirements.txt
RUN uv pip install -e .

@DoctorJohn DoctorJohn Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original requirements.txt file also installed the tests and docs dependency groups. So technically, we should either go with:

Suggested change
RUN uv pip install -e .
RUN uv sync

or, if we want to use the pip interface:

Suggested change
RUN uv pip install -e .
RUN uv pip install --group tests --group docs --editable .

I'd go with the first option, which syncs the projects dependencies and the dev dependency group, which also includes the tests and docs dependency groups.
Tho, I must admit I'm not even sure this Dockerfile is even used anymore.

Loading