feat: publish custom agent manifest schema#382
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
Kinfe123
marked this pull request as ready for review
July 24, 2026 21:51
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 27 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:31">
P2: Filtered package test runs can fail with `MODULE_NOT_FOUND` because `@farming-labs/docs` and `@farming-labs/theme` now import these validators without declaring them. Adding `ajv` and `ajv-formats` to the devDependencies of the packages that own these tests would make their test dependencies explicit.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| "@farming-labs/next": "workspace:*", | ||
| "@farming-labs/theme": "workspace:*", | ||
| "@tailwindcss/postcss": "^4.1.18", | ||
| "ajv": "^8.18.0", |
Contributor
There was a problem hiding this comment.
P2: Filtered package test runs can fail with MODULE_NOT_FOUND because @farming-labs/docs and @farming-labs/theme now import these validators without declaring them. Adding ajv and ajv-formats to the devDependencies of the packages that own these tests would make their test dependencies explicit.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 31:
<comment>Filtered package test runs can fail with `MODULE_NOT_FOUND` because `@farming-labs/docs` and `@farming-labs/theme` now import these validators without declaring them. Adding `ajv` and `ajv-formats` to the devDependencies of the packages that own these tests would make their test dependencies explicit.</comment>
<file context>
@@ -28,6 +28,8 @@
"@farming-labs/next": "workspace:*",
"@farming-labs/theme": "workspace:*",
"@tailwindcss/postcss": "^4.1.18",
+ "ajv": "^8.18.0",
+ "ajv-formats": "^3.0.1",
"bumpp": "^10.4.1",
</file context>
Contributor
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/smoke-agent-surfaces.mjs">
<violation number="1" location="scripts/smoke-agent-surfaces.mjs:318">
P3: `includesLinkRelation` is now dead local code after this switch to `includesTypedLinkRelation`. Removing the obsolete helper avoids maintaining two Link-header matching implementations.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| assert(manifest.version === "1", `${route} did not declare agent manifest version 1`); | ||
| assert(isNonEmptyString(manifest.name), `${route} did not declare a name`); | ||
| assert( | ||
| includesTypedLinkRelation( |
Contributor
There was a problem hiding this comment.
P3: includesLinkRelation is now dead local code after this switch to includesTypedLinkRelation. Removing the obsolete helper avoids maintaining two Link-header matching implementations.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/smoke-agent-surfaces.mjs, line 318:
<comment>`includesLinkRelation` is now dead local code after this switch to `includesTypedLinkRelation`. Removing the obsolete helper avoids maintaining two Link-header matching implementations.</comment>
<file context>
@@ -253,12 +314,14 @@ function validateManifest(json, route, response) {
assert(
- /type=(?:"application\/schema\+json"|application\/schema\+json)(?:[,;]|$)/iu.test(link),
- `${route} omitted the manifest schema media type`,
+ includesTypedLinkRelation(
+ response,
+ AGENT_MANIFEST_SCHEMA,
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/.well-known/agent.jsonextension$schemaandformatfields plus a scopedrel="describedby"HTTP Link across Next.js, TanStack Start, Astro, SvelteKit, and Nuxt/.well-known/agent-card.jsonserovalandpostcsstransitive advisories surfaced by CICompatibility
This is additive. The custom manifest remains
application/json, existing consumers can continue reading its current fields, and the A2A Agent Card wire format is unchanged.Verification
docs-websiteVercel preview passedBaseline check
The secondary
farming-labs-docs-docs-cloudVercel project still reports the same Nuxtacorn-jsxinstall-cache failure present onmain; it is not introduced by this branch.