Skip to content

fix(docsite): show CheckIndicator in properties preview - #5972

Merged
cixzhang merged 2 commits into
facebook:mainfrom
Kyujenius:fix/check-indicator-preview
Sep 3, 2026
Merged

fix(docsite): show CheckIndicator in properties preview#5972
cixzhang merged 2 commits into
facebook:mainfrom
Kyujenius:fix/check-indicator-preview

Conversation

@Kyujenius

@Kyujenius Kyujenius commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Start the CheckIndicator Properties preview in its visible checked state.
  • Cover the generated component registry default so the preview cannot silently regress to an empty stage.

Fixes #5890

Verification

  • pnpm -F @astryxdesign/docsite generate && pnpm -F @astryxdesign/docsite test (456 tests passed)
  • pnpm -F @astryxdesign/core typecheck:docs

Screenshot

AS-IS TO-BE
image screenshot-2026-09-04

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 3, 2026 5:53pm UTC

Request Review

@meta-cla

meta-cla Bot commented Sep 3, 2026

Copy link
Copy Markdown

Hi @Kyujenius!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions Bot added community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge labels Sep 3, 2026
@Kyujenius
Kyujenius marked this pull request as ready for review September 3, 2026 16:54
@meta-cla

meta-cla Bot commented Sep 3, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 3, 2026

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the preview fix and regression test are good. Please add a @astryxdesign/core patch changeset so this packaged docs update ships with release notes and contributor credit.

[Reviewed by Robohands]

@Kyujenius

Copy link
Copy Markdown
Contributor Author

@cixzhang
Thanks! 👍 Added the changeset and went ahead and added one to #5976 too.

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good. The patch changeset now carries the CheckIndicator preview fix and contributor credit into the core release notes.

[Reviewed by Robohands]

@cixzhang
cixzhang enabled auto-merge (squash) September 3, 2026 21:13
@github-actions github-actions Bot removed the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Sep 3, 2026
@cixzhang
cixzhang merged commit 62b86f9 into facebook:main Sep 3, 2026
27 of 29 checks passed
github-actions Bot added a commit that referenced this pull request Sep 3, 2026
josephfarina pushed a commit that referenced this pull request Sep 4, 2026
* fix(docsite): show CheckIndicator in properties preview

* chore: add changeset for CheckIndicator preview fix
@github-actions
github-actions Bot deleted the fix/check-indicator-preview branch September 4, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. community Authored by a community contributor (not on the eng/design team)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CheckIndicator Properties preview renders no working component

2 participants