Repository navigation
fix: point blog "Edit on GitHub" link at the source file - #2567
Open
NopeCharon wants to merge 1 commit into
Open
NopeCharon wants to merge 1 commit into
NopeCharon wants to merge 1 commit into
Conversation
The link was built from the route's slug param, which has no file extension and is lowercased, so it pointed at a path that does not exist on GitHub for every blog post. Use post.filePath, as the docs route already does with page.filePath, so the link keeps the real filename and extension. Add an e2e test covering a mixed-case .md post and a mixed-case .mdx post. Fixes expressjs#2565 Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2565
Edit on GitHub is broken on every blog post because the URL is built from the route's slug, which has no extension and is lowercased. It now uses
post.filePath, the same way the docs route usespage.filePath.src/content/blog/2026-10-28-cve-2026-111181src/content/blog/2026-10-28-CVE-2026-111181.mdxValidation
tests/e2e/blog.spec.tscovers a mixed-case.mdpost and a mixed-case.mdxpost.astro devin Chromium, both tests pass with the fix and fail without it. I didn't run Firefox or WebKit locally.