You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: require recommended: false to meta - #615
I used AI to write or edit the description of this PR (including translation).
I used AI to understand the codebase.
I used AI to write or edit the files in this PR and I reviewed the files.
What is the purpose of this pull request?
This PR ports the change from eslint/markdown#760, adding an explicit recommended: false to each rule’s meta object.
What changes did you make? (Give an overview)
Added recommended: false field and enforced it with "eslint-plugin/require-meta-docs-recommended": "error".
Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit
Developer Tooling
Updated linting configuration to require documentation metadata for CSS rules.
Several CSS lint rules are now explicitly marked as not recommended by default. Their existing checks remain unchanged; they continue to evaluate stylesheets and report violations as before. These updates affect lint configuration and rule classification only, without changing the behavior of the rules.
eslint/css#606: Removes recommended: false from two rules that set this metadata in this PR.
Suggested reviewers:nzakas
Merge Risk: Minimal · up to 93f53
This change only adds rule metadata and a lint check that enforces it. Rule behavior is unchanged, and no merge-blocking risk remains.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title describes the rule metadata change and its enforcement.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 5 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Central YAML; Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 9cb3826f-2e77-4290-a678-f117c3e8b41b
Commits
Reviewing files that changed from the base of the PR and between 914fe6c and 93f5318.
Files selected for processing: 4
src/rules/prefer-logical-properties.js
src/rules/relative-font-units.js
src/rules/selector-complexity.js
src/rules/use-layers.js
Files skipped from review as they are similar to previous changes: 4
src/rules/use-layers.js
src/rules/relative-font-units.js
src/rules/prefer-logical-properties.js
src/rules/selector-complexity.js
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acceptedThere is consensus among the team that this change meets the criteria for inclusionchore
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
Check all that apply.
What is the purpose of this pull request?
This PR ports the change from eslint/markdown#760, adding an explicit
recommended: falseto each rule’smetaobject.What changes did you make? (Give an overview)
Added
recommended: falsefield and enforced it with"eslint-plugin/require-meta-docs-recommended": "error".Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit