Skip to content

refactor: require recommended: false to meta - #615

Merged
Tanujkanti4441 merged 2 commits into
mainfrom
refactor/require-recommended-false-to-meta
Nov 6, 2026
Merged

Tanujkanti4441 merged 2 commits into
mainfrom
refactor/require-recommended-false-to-meta

Conversation

@lumirlumir

@lumirlumir lumirlumir commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Prerequisites checklist

AI acknowledgment

Check all that apply.

  • I did not use AI to generate this PR.
  • I used AI to write or edit the description of this PR (including translation).
  • I used AI to understand the codebase.
  • I used AI to write or edit the files in this PR and I reviewed the files.

What is the purpose of this pull request?

This PR ports the change from eslint/markdown#760, adding an explicit recommended: false to each rule’s meta object.

What changes did you make? (Give an overview)

Added recommended: false field and enforced it with "eslint-plugin/require-meta-docs-recommended": "error".

Related Issues

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

  • Developer Tooling
    • Updated linting configuration to require documentation metadata for CSS rules.
    • Several CSS lint rules are now explicitly marked as not recommended by default. Their existing checks remain unchanged; they continue to evaluate stylesheets and report violations as before. These updates affect lint configuration and rule classification only, without changing the behavior of the rules.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CSS rules configuration now requires recommended metadata. Four rules set their metadata to not recommended. Rule behavior is unchanged.

Changes: Rule Metadata

Layer / File(s) Summary
Require and declare recommended metadata
eslint.config.js, src/rules/prefer-logical-properties.js, src/rules/relative-font-units.js, src/rules/selector-complexity.js, src/rules/use-layers.js
The CSS rules configuration enables eslint-plugin/require-meta-docs-recommended as an error. The four rules set recommended to false.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

  • eslint/css#606: Removes recommended: false from two rules that set this metadata in this PR.

Suggested reviewers: nzakas

Merge Risk: Minimal · up to 93f53

This change only adds rule metadata and a lint check that enforces it. Rule behavior is unchanged, and no merge-blocking risk remains.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the rule metadata change and its enforcement.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 5 files.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9cb3826f-2e77-4290-a678-f117c3e8b41b
Commits

Reviewing files that changed from the base of the PR and between 914fe6c and 93f5318.

Files selected for processing: 4

  • src/rules/prefer-logical-properties.js
  • src/rules/relative-font-units.js
  • src/rules/selector-complexity.js
  • src/rules/use-layers.js
Files skipped from review as they are similar to previous changes: 4

  • src/rules/use-layers.js
  • src/rules/relative-font-units.js
  • src/rules/prefer-logical-properties.js
  • src/rules/selector-complexity.js

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 6, 2026

@Tanujkanti4441 Tanujkanti4441 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Tanujkanti4441
Tanujkanti4441 merged commit c360166 into main Nov 6, 2026
39 checks passed
@Tanujkanti4441
Tanujkanti4441 deleted the refactor/require-recommended-false-to-meta branch November 6, 2026 11:17
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants