Update field_statistics to use individual ertbox per zone - #858
Open
oddvarlia wants to merge 2 commits into
Open
Update field_statistics to use individual ertbox per zone#858oddvarlia wants to merge 2 commits into
oddvarlia wants to merge 2 commits into
Conversation
oddvarlia
marked this pull request as draft
April 10, 2026 11:15
oddvarlia
force-pushed
the
update_field_statistics_with_zone_dependent_ertbox_grid
branch
from
April 18, 2026 12:56
8777229 to
0512285
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 84.51% 84.26% -0.26%
==========================================
Files 49 49
Lines 7349 7498 +149
==========================================
+ Hits 6211 6318 +107
- Misses 1138 1180 +42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oddvarlia
force-pushed
the
update_field_statistics_with_zone_dependent_ertbox_grid
branch
6 times, most recently
from
April 21, 2026 10:47
c7630cf to
335b994
Compare
oddvarlia
marked this pull request as ready for review
April 21, 2026 15:00
oddvarlia
marked this pull request as draft
April 30, 2026 13:15
oddvarlia
force-pushed
the
update_field_statistics_with_zone_dependent_ertbox_grid
branch
7 times, most recently
from
May 6, 2026 21:40
4d70873 to
c2443be
Compare
Some model file changes from previous version was required Documentation is updated.
oddvarlia
force-pushed
the
update_field_statistics_with_zone_dependent_ertbox_grid
branch
from
May 6, 2026 21:43
c2443be to
a7fdb52
Compare
oddvarlia
marked this pull request as ready for review
May 6, 2026 21:54
alifbe
requested changes
Jul 23, 2026
alifbe
left a comment
alifbe
left a comment
Collaborator
There was a problem hiding this comment.
Not quite sure if the files in ensemble/share/grid_statistics/ are all needed.
In general, we should avoid code repetitions.
oddvarlia
force-pushed
the
update_field_statistics_with_zone_dependent_ertbox_grid
branch
5 times, most recently
from
August 6, 2026 07:28
cddfb7c to
8771364
Compare
oddvarlia
force-pushed
the
update_field_statistics_with_zone_dependent_ertbox_grid
branch
from
August 7, 2026 08:55
8771364 to
7d5966f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #842