Skip to content

Stop excluding self-actions from PR notifications - #15

Merged
emmahsax merged 3 commits into
mainfrom
notify-self-reviews
Oct 30, 2026
Merged

emmahsax merged 3 commits into
mainfrom
notify-self-reviews

Conversation

@emmahsax

@emmahsax emmahsax commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • No notification trigger excludes the user's own action anymore. Reviews (approve/request-changes/comment), comments (issue + inline review comments), and pushed commits all now notify regardless of who performed the action, matching merges/labels/reopen/close which never excluded the actor.
  • CON-001's existing suppression of a contentless "commented" review (empty/whitespace body) is unaffected — that's a content-based suppression, not actor-based.
  • Design doc updated: REQ-022 now covers all three previously-self-excluded event kinds, REQ-019's old self-push exclusion is marked superseded (kept for history), and AC-025/AC-033–036 updated/added.

Test plan

  • go build ./...
  • go test ./...
  • gofmt -l . / go vet ./... clean
  • Updated/added unit tests in internal/handler/handler_test.go for: self-review still notifies, self-comment (issue + inline) still notifies, self-pushed-commit still notifies, and self-review with contentless "commented" body still suppressed

emmahsax and others added 2 commits October 30, 2026 11:36
Previously a review's self-notification exclusion matched comments and
commits, but the user wants a Slack record of their own review
verdicts too. Adds REQ-022/AC-033..035 to the design doc; CON-001's
empty-body suppression for contentless "commented" reviews still
applies regardless of actor.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Extends the self-review change: a self-authored comment (issue or
inline review comment) and a self-pushed commit now also notify,
matching reviews. No notification trigger excludes the user's own
action anymore — the thread is meant to be a full activity record.

Updates REQ-022 to cover all three event kinds, marks REQ-019's old
self-push exclusion as superseded, and adds AC-025/AC-036.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@emmahsax emmahsax changed the title Notify on self-submitted reviews (approve/request changes/comment) Stop excluding self-actions from PR notifications Oct 30, 2026
@emmahsax
emmahsax marked this pull request as ready for review October 30, 2026 16:46
@emmahsax
emmahsax merged commit 0df4cdb into main Oct 30, 2026
9 checks passed
@emmahsax
emmahsax deleted the notify-self-reviews branch October 30, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant