Repository navigation
Stop excluding self-actions from PR notifications - #15
Merged
Merged
Conversation
Previously a review's self-notification exclusion matched comments and commits, but the user wants a Slack record of their own review verdicts too. Adds REQ-022/AC-033..035 to the design doc; CON-001's empty-body suppression for contentless "commented" reviews still applies regardless of actor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Extends the self-review change: a self-authored comment (issue or inline review comment) and a self-pushed commit now also notify, matching reviews. No notification trigger excludes the user's own action anymore — the thread is meant to be a full activity record. Updates REQ-022 to cover all three event kinds, marks REQ-019's old self-push exclusion as superseded, and adds AC-025/AC-036. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go build ./...go test ./...gofmt -l ./go vet ./...cleaninternal/handler/handler_test.gofor: self-review still notifies, self-comment (issue + inline) still notifies, self-pushed-commit still notifies, and self-review with contentless "commented" body still suppressed