Repository navigation
fix: remove unused stale copy of src/formats.ts - #2041
DoctorGuidance wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove the stale format registry src/formats.ts |
The file and its format-name type, registry, patterns, and validation helpers are removed. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: saltyaom
Merge Risk: 
Minimal · up to fb33b
-
The deletion preserves the supported format APIs and their implementation. No actionable merge-blocking risk remains.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description includes the required sections, linked issue, change rationale, affected build output, and AI policy disclosure. It is sufficiently detailed, although it does not specify the required bun run test command.
Full details: Linked Issues check
-
Explanation
Issue
#2021requires deletion of the unused stalesrc/formats.tscopy. The pull request deletes that file and leaves live format definitions insrc/type-system/format.ts, as stated in the PR description. The change addresses the stale build artifact without requiring unrelated runtime changes. Cute little duplicate, gone at last~ ♡
Full details: Out of Scope Changes check
-
Explanation
The reviewed change only deletes
src/formats.ts, including its obsoleteFormatNameandfullFormatsexports. This change directly supports issue#2021and shows no unrelated implementation or test changes. Nothing out of scope here, unlike that stale file~ ( ̄▽ ̄)♡
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
One old format file takes its bow~ ♡
Its registry is gone now, you noticed? ( ̄▽ ̄)
The validators leave with it too~
No runtime change is reported here ♡
A tidy little diff, not bad, huh~ (¬‿¬)
Prerequisted
Related issue
Fixes #2021
Description
src/formats.tswas an unreferenced, outdated duplicate ofsrc/type-system/format.ts.Because
build.tsbuildssrc/**/*.ts, this duplicate was compiled intodist/formats.jsanddist/formats.mjseven though neither Elysia core norpackage.jsonexports it.This PR removes
src/formats.ts. All live format definitions and registries continue to be served bysrc/type-system/format.tsand exported viasrc/type-system/index.ts.I have nothing but my burger and I want nothing more
Summary by CodeRabbit