docs(bigshot.lic): v5.16.0 add YARD documentation throughout - #2417
Open
mrhoribu wants to merge 1 commit into
Open
docs(bigshot.lic): v5.16.0 add YARD documentation throughout#2417mrhoribu wants to merge 1 commit into
mrhoribu wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mrhoribu
force-pushed
the
docs/bigshot-yard-documentation
branch
from
August 17, 2026 23:38
a220059 to
040978f
Compare
Full YARD pass: 296 of 296 methods now carry @param/@return (plus @raise/@note/@see/@yieldparam where relevant), and DebugLogger, Event, BSAreaRooms, and Group each get a class-level doc explaining their role. No behavior change - pure documentation. Written from reading each method body, not generated from signatures, so several carry information the code doesn't state on its face: - Group#member_online documents why nearly every Group method funnels through it: a follower whose Lich has exited raises DRb::DRbConnError on access, and the group has to survive that rather than letting it propagate into the leader's hunting loop. - Bigshot#ping's doc records that its `true` return value is irrelevant - the point is that a dead follower raises on the call itself, which is what actually gets it dropped. - add_event notes that :ATTACK is dropped once a follower's event stack backs up, so a lagging follower doesn't accumulate stale attack orders. - BSAreaRooms#build flags that it exits the script past 200 rooms, on the assumption the boundaries are misconfigured rather than the area genuinely being that large. - check_state_condition and initialize_command_data cross-reference each other via @note: a new command-check modifier added to one and not the other silently never parses. Two mistakes caught and fixed during this pass, both confirmed to predate this commit (i.e. present in the file this PR is based on, not introduced by it): a duplicated description line on BigshotCreature#gameobj, and an identical duplication on still_targetable?, both artifacts of appending a short YARD summary above a method that already had a full prose comment without checking for one first. Fixed in place; a full-file scan confirmed no other instances of the pattern.
mrhoribu
force-pushed
the
docs/bigshot-yard-documentation
branch
from
August 17, 2026 23:54
040978f to
f6d059c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(bigshot.lic): v5.16.0 add YARD documentation throughout
Full YARD pass: 296 of 296 methods now carry @param/@return (plus
@raise/@note/@see/@yieldparam where relevant), and DebugLogger, Event,
BSAreaRooms, and Group each get a class-level doc explaining their
role. No behavior change - pure documentation.
Written from reading each method body, not generated from signatures,
so several carry information the code doesn't state on its face:
through it: a follower whose Lich has exited raises
DRb::DRbConnError on access, and the group has to survive that
rather than letting it propagate into the leader's hunting loop.
truereturn value isirrelevant - the point is that a dead follower raises on the call
itself, which is what actually gets it dropped.
stack backs up, so a lagging follower doesn't accumulate stale
attack orders.
on the assumption the boundaries are misconfigured rather than the
area genuinely being that large.
each other via @note: a new command-check modifier added to one
and not the other silently never parses.
Two mistakes caught and fixed during this pass, both confirmed to
predate this commit (i.e. present in the file this PR is based on, not
introduced by it): a duplicated description line on
BigshotCreature#gameobj, and an identical duplication on
still_targetable?, both artifacts of appending a short YARD summary
above a method that already had a full prose comment without checking
for one first. Fixed in place; a full-file scan confirmed no other
instances of the pattern.