fix(web): drive history period filters from recorded data - #81
Merged
Conversation
Replace the unreliable native month input with year/month selects and list only years and months that actually have trips, fuel logs, or maintenance records via a new history-periods endpoint. Co-authored-by: Cursor <cursoragent@cursor.com>
Selecting a year in month mode cleared the applied filter, which wiped the year dropdown back to its placeholder before a month could be picked. Also drop the AT TIME ZONE conversion: the date columns are timestamp without time zone holding UTC wall clock values, so converting them made the month buckets depend on the database session timezone. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input type="month"(picker does not open in Safari/Firefox) with year + month<select>pairGET /api/vehicles/:id/history-periods?scope=trips|fuel|maintenancereturning only years/months that have recordsTest plan
npm run buildpassesMade with Cursor