fix: allow local Brain to bind folders outside home directory - #1849
Open
xdCloudy wants to merge 2 commits into
Open
fix: allow local Brain to bind folders outside home directory#1849xdCloudy wants to merge 2 commits into
xdCloudy wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix local workspace binding for folders that live outside the user's home directory or
EIGENT_WORKSPACE.Local desktop deployments are detected with
filesystem_scope="full", butEnvironmentHands.can_access_filesystem()was still restricting that scope to the home directory and configured workspace root. On Windows this rejects valid folders on another drive (for exampleD:\...) and surfaces as:The change makes
fullmean unrestricted filesystem capability as declared byBrainCapabilities, while leavingworkspace_onlyunchanged for sandbox/container deployments.Changes
filesystem_scope == "full"workspace_onlyrestricted to the configured workspace rootPath existence and directory validation remain in the workspace binding endpoint, so this only fixes the capability check; it does not bypass normal bind-path validation.
Validation
Validated on Windows with a local Brain by binding a folder outside the user profile / workspace root, including a folder on
D:. The previous code rejects that path; this change allows it while theworkspace_onlyregression test still rejects paths outside its workspace.Fixes #1766