Read theme from authStore instead of next-themes - #1846
Open
Octagon-simon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Fixes #1845
Description
The toast component
src/components/ui/sonner.tsxread its theme from next-themes'suseTheme() (const { theme = 'system' } = useTheme()), which did not reflect the app's actually-resolved theme. That's why the toast box rendered with colors that didn't match the device theme.So I changed the Toaster to read the resolved appearance from the app's theme store instead.
Testing Evidence (REQUIRED)
Before:
After:
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement