fix: prevent LineChart crash when popup path data is empty#170
Open
saadkhalidkhan wants to merge 1 commit into
Open
fix: prevent LineChart crash when popup path data is empty#170saadkhalidkhan wants to merge 1 commit into
saadkhalidkhan wants to merge 1 commit into
Conversation
saadkhalidkhan
force-pushed
the
fix/linechart-empty-data-popup-crash
branch
from
a98d081 to
bfcc760
Compare
Guard showPopup and pointer input handlers against empty data and linesPathData to prevent IndexOutOfBoundsException during drag/tap. Fixes ehsannarmani#146, ehsannarmani#158, ehsannarmani#114
saadkhalidkhan
force-pushed
the
fix/linechart-empty-data-popup-crash
branch
from
bfcc760 to
d950d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showPopupagainst emptydata, emptylinesPathData, and size mismatches between themgetOrNullaccess when reading path data per line indexpointerInputkeys so handlers rebind when chart data changesThis prevents
IndexOutOfBoundsExceptionwhen interacting with aLineChartbefore path data is populated, or when the chart has no data.Fixes #146
Fixes #158
Fixes #114
Test plan
:compose-charts:compileDebugKotlinAndroidlocallyLineChartwith an emptydatalist and drag/tap on the chart — no crashLineChartwith valid data and verify popup drag/tap still works