Typed Rust explicit installation, shared programs, and recording - #76
Closed
saulshanabrook wants to merge 1 commit into
Closed
saulshanabrook wants to merge 1 commit into
saulshanabrook wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Stacked on #74. Add explicit installation and shared-program export/recording to the typed Rust frontend, addressing the Luminal review without changing its execution algorithms.
Uses the published core revision from egglog#1027.
Changes
EGraph::installaccepts sort descriptions, selected declarations, rules, and rulesets; it installs dependencies but never creates rows or runs rules.ProgramBuilderassembles the same commands offline, including scopes, with atomic preflight failures and no EGraph.Program; scoped recording retains native outcomes and actual submitted scope commands.Normal expressions do not need descriptor objects. Explicit callable installation uses the existing selector mechanism. Imported core records do not automatically reconstruct typed authoring metadata. Direct observations/extractors are not invented as recorded commands.
Validation
Typed runtime suites, 47 example mains, 35 compile-fail cases, 15 doctests, and nine focused program tests passed. Independent review replayed equivalent offline and recorded 14-command programs and confirmed installation produced no tuples. Scoped strict Clippy passed with only the unchanged
replace_boxlint allowed. The original dirty review worktree remains untouched.