feat: add no_std + alloc support behind std feature gate - #364
Merged
Merged
Conversation
Port the entire crate to work without the standard library by gating std-only dependencies (env_logger, quanta, symbol_table, symbolic_expressions) behind a default "std" feature. When std is disabled, a minimal sexp parser, a spin-lock-based global symbol interner, and a no-op Instant shim fill in. Bumps thiserror to v2 for no_std error derive support. Closes egraphs-good#361
Member
|
Hi, this is an interesting contribution, but it's not ready. To merge this, I'd like to consolidate most import changes into a shim thing in |
Member
|
Looks good. I've added no_std support to the symbol_table library. Please depend on it's latest commit and then looks should be good to go. https://github.com/mwillsey/symbol_table |
Max added no_std support to symbol_table upstream, so egg no longer needs its hand-rolled Symbol shim. Pin symbol_table to the no_std commit on mwillsey/symbol_table and drop the no_std_symbol module.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the entire crate to work without the standard library by gating std-only dependencies (env_logger, quanta, symbol_table, symbolic_expressions) behind a default "std" feature. When std is disabled, a minimal sexp parser, a spin-lock-based global symbol interner, and a no-op Instant shim fill in. Bumps thiserror to v2 for no_std error derive support.
Closes #361