Skip to content

Fix bugs initializing stretched and pasted tables. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btrewern wants to merge 4 commits into
base: master
Choose a base branch
from
+31 −3
Open

Fix bugs initializing stretched and pasted tables. #190

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e9e0f4
Fix initializing and saving stretched.
btrewern Jul 23, 2026
109af1e
Set stretched after pasting.
btrewern Jul 23, 2026
0dfccf3
Add comment
btrewern Jul 23, 2026
982fee2
Revert unintended change.
btrewern Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions src/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,18 @@ export default class TableBlock {
return this.container;
}

/**
* Hook called after the block is fully rendered and mounted
* Set this.block.stretched here as block is not initialized in render().
*
* @returns {void}
*/
rendered() {
if (this.block) {
this.block.stretched = !!this.data.stretched;
}
}

/**
* Returns plugin settings
*
Expand All @@ -119,7 +131,7 @@ export default class TableBlock {
toggle: true,
onActivate: () => {
this.data.withHeadings = true;
this.table.setHeadingsSetting(this.data.withHeadings);
this._updateTunes();
}
}, {
label: this.api.i18n.t('Without headings'),
Expand All @@ -129,7 +141,7 @@ export default class TableBlock {
toggle: true,
onActivate: () => {
this.data.withHeadings = false;
this.table.setHeadingsSetting(this.data.withHeadings);
this._updateTunes();
}
}, {
label: this.data.stretched ? this.api.i18n.t('Collapse') : this.api.i18n.t('Stretch'),
Expand All @@ -138,11 +150,26 @@ export default class TableBlock {
toggle: true,
onActivate: () => {
this.data.stretched = !this.data.stretched;
this.block.stretched = this.data.stretched;
this._updateTunes();
}
}
];
}

/**
* Handle updating UI for tunes
*
* @returns {void}
*/
_updateTunes() {
this.table.setHeadingsSetting(this.data.withHeadings);

if (this.block) {
this.block.stretched = !!this.data.stretched;
this.block.dispatchChange();
}
}

/**
* Extract table data from the view
*
Expand Down Expand Up @@ -222,6 +249,7 @@ export default class TableBlock {
/** Update Tool's data */
this.data = {
withHeadings: firstRowHeading !== null,
stretched: false,
content
};
Comment thread
neSpecc marked this conversation as resolved.

Expand Down