Skip to content

Prevent GCC warnings #104

Description

@ikmsk10

Some code of the fastcgipp has the following warnings:

../subprojects/fastcgi++/include/fastcgi++/protocol.hpp:366:29: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion]
  366 |             uint8_t padding[paddingLength];
      |                             ^~~~~~~~~~~~~
In file included from ../src/core/application.hpp:7,
                 from ../src/core/route/handlers/graphql_handler.cpp:6:
../subprojects/fastcgi++/include/fastcgi++/manager.hpp:64:11: warning: 'class Fastcgipp::Manager_base' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
   64 |     class Manager_base

I'd prefer to remedy -Wnon-virtual-dtor, -Wsign-conversio, -Wunused-parameter corresponding code which given these warnings for possible using the library with the -pedantic and -Werror.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions