Repository navigation
Conversation
Signed-off-by: dkm <2094657017@qq.com>
Contributor
|
but this will break the extraction of tests which do not live in the current SUMO_HOME, doesn't it? |
Walk up to the closest directory containing a testsuite instead of stopping immediately when the test is not below SUMO_HOME/tests. This keeps inherited options and configs for external tests while still avoiding unrelated files such as SUMO_HOME/data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18384.
The recursive walk in
extractTest.pyonly stopped atSUMO_HOME/tests(or the filesystem root). When extracting a test that is not located below that directory it walked upwards and picked up unrelated files such asSUMO_HOME/data.The walk now stops at
SUMO_HOME/testsfor tests inside the tests tree. For external tests it stops at the closest ancestor containing atestsuite.*file, or at the test directory itself when no suite exists. This keeps inheritedoptions.*andconfig.*files working for external test suites without including unrelated sibling directories.Local verification: extracting an external suite case inherited the suite's
--begin 0option; extracting a standalone external case did not include sibling directories; a synthetic suite insideSUMO_HOME/testsstill inherited its options.