Repository navigation
Conversation
Signed-off-by: dkm <2094657017@qq.com>
Negative arrival positions are relative to the end of the edge and are interpreted later, so comparing them at load time produces false warnings for existing tests. Keep the warning for explicit positive arrival positions where the comparison is meaningful. Refs eclipse-sumo#5928
The expected file was a single newline, but the test produces no output at all. An empty file matches the actual output.
The expected file had a CRLF line ending while SUMO writes LF on Linux and macOS, which made the wheel tests report differences in errors.
NearCai
force-pushed
the
pr/single-edge-arrivalpos
branch
from
October 30, 2026 15:46
be603b7 to
0f05c76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5928.
For a route consisting of a single edge, an explicit
arrivalPosthat is not greaterthan an explicit
departPoscannot be reached (the vehicle would have to drivebackwards). This adds a warning at load time:
The behaviour itself is unchanged. A regression test
(
tests/complex/traci/vehicle/singleEdgeArrivalPos) is included.Local verification: built
sumoand ran the new test; warning matches the expected output.