Repository navigation
Conversation
Signed-off-by: dkm <2094657017@qq.com>
Contributor
|
I see your point because we are not very consistent here. Sometimes we group by topic (the devices) and sometimes by input/output etc. Still I think it is confusing to change it now. @namdre Opinions? |
Contributor
|
My weak preference is to keep the output-related options in the output category. Putting the others into a new 'Persons' category is fine though. I'd also prefer to move the pedestrian options that are now in 'Processing' to the new category. |
Keep the person output options in Output, but move the non-output person options and the pedestrian model options from Processing to the new Persons category. This follows the review discussion on the category layout. Fixes eclipse-sumo#6374
NearCai
force-pushed
the
pr/persons-category
branch
from
October 29, 2026 07:00
5e3dce2 to
3d9467c
Compare
Contributor
Author
|
Thanks for the guidance. I updated the PR accordingly:
I rebuilt locally and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6374.
Person-related simulation options were spread over the generic
Output,Processingand
Routinghelp sections. Following the review discussion, the newPersonscategory contains only non-output person options:
max-num-persons,time-to-teleport.ride,pedestrian.*(the pedestrian modeloptions that were previously in
Processing) and allpersontrip.*options, plusride.stop-tolerance.The person output options (
person-fcd-output,person-summary-output,personinfo-output,personroute-output) andsave-state.transportablesremain inOutput. The JuPedSim WKT/Python output options also remain inOutput.Local verification: built
sumoandsumo --helpshows aPersons Options:section with the non-output options, while the person output options are still
listed under
Output Options:.