Skip to content

Cleaned up bundle dependencies, updated required EE to Java 25 - #3005

Merged
iloveeclipse merged 2 commits into
eclipse-platform:masterfrom
iloveeclipse:java_25
Oct 10, 2026
Merged

iloveeclipse merged 2 commits into
eclipse-platform:masterfrom
iloveeclipse:java_25

Conversation

@iloveeclipse

Copy link
Copy Markdown
Member
  • Cleaned up bundle dependencies, updated required EE to Java 25 where needed
  • Applied "Rename to unnamed variable" quick fix

@vogella

vogella commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Mass changes via an automatic clean-up from @iloveeclipse.

Times are indeed are changing. Thanks @iloveeclipse for this cleanup, that made my day. :-) (Just for completeness: I did not verify the change)

@iloveeclipse

Copy link
Copy Markdown
Member Author

The switch to Java 25 is necessary / overdue and must be done early enough. The follow up cleanup removes stupid warnings caused by that switch.

@iloveeclipse

Copy link
Copy Markdown
Member Author

BTW I've verified all the changes manually, while doing so I've found eclipse-platform/eclipse.platform.swt#3703.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   58m 21s ⏱️ + 4m 44s
 4 862 tests ±0   4 840 ✅ +1   22 💤 ±0  0 ❌ ±0 
12 477 runs  ±0  12 323 ✅ +1  154 💤 ±0  0 ❌ ±0 

Results for commit 9635262. ± Comparison against base commit c7c6e48.

♻️ This comment has been updated with latest results.

@iloveeclipse

Copy link
Copy Markdown
Member Author

Build succeeds, but fails with OOM processing test results

07:51:33.415 [INFO] ------------------------------------------------------------------------
07:51:33.415 [INFO] BUILD SUCCESS
07:51:33.415 [INFO] ------------------------------------------------------------------------
07:51:33.415 [INFO] Total time:  40:48 min
07:51:33.415 [INFO] Finished at: 2026-10-10T07:51:33Z
07:51:33.415 [INFO] ------------------------------------------------------------------------
[Pipeline] }
Terminating xvnc.

Sat Oct 10 07:51:34 2026
 ComparingUpdateTracker: 0 pixels in / 0 pixels out
 ComparingUpdateTracker: (1:-nan ratio)
[Pipeline] // xvnc
Post stage
[Pipeline] archiveArtifacts
Archiving artifacts
[Pipeline] junit
Recording test results
Remote call on JNLP4-connect connection from 10.40.23.239/10.40.23.239:49614 failed
Error when executing always post condition:
java.lang.OutOfMemoryError: Java heap space
	at java.base/java.util.Arrays.copyOf(Arrays.java:3541)
	at java.base/java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:242)
	at java.base/java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:592)
	at java.base/java.lang.StringBuffer.append(StringBuffer.java:313)
	at org.dom4j.io.SAXContentHandler.characters(SAXContentHandler.java:285)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.characters(AbstractSAXParser.java:555)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:517)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:889)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:825)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1224)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:637)
	at org.dom4j.io.SAXReader.read(SAXReader.java:494)
	at org.dom4j.io.SAXReader.read(SAXReader.java:392)
	at hudson.tasks.junit.SuiteResult.parse(SuiteResult.java:366)
	at hudson.tasks.junit.TestResult.parse(TestResult.java:607)
	at hudson.tasks.junit.TestResult.parsePossiblyEmpty(TestResult.java:521)
	at hudson.tasks.junit.TestResult.parse(TestResult.java:457)
	at hudson.tasks.junit.TestResult.parse(TestResult.java:439)
	at hudson.tasks.junit.TestResult.parse(TestResult.java:416)
	at hudson.tasks.junit.TestResult.<init>(TestResult.java:262)
	at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:238)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3655)
	at hudson.remoting.UserRequest.perform(UserRequest.java:225)
	at hudson.remoting.UserRequest.perform(UserRequest.java:50)
	at hudson.remoting.Request$2.run(Request.java:391

Note: there will be `The constructor URL(String) is deprecated since
version 20` warnings, however refactoring the code is not trivial
because one must make sure the caller can properly decode the
URI.toURL() result which will contain %20 instead of space and that will
break all file based operations of caller.
Compiler reported "The value of the lambda parameter event is not used"
warnings after updating source level to Java 25 => applied "Rename to
unnamed variable" quick fix
@iloveeclipse

Copy link
Copy Markdown
Member Author

Mac test failure is not stable test, not related. 3 tests fails on Jenkins also unrelated, like before we see IOException: Server returned HTTP response code: 503 for URL: https://github.com/eclipse-platform/eclipse.platform/blob/master/ua/org.eclipse.tips.tests/icons/dummy.png

@merks

merks commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

I don't think those new warnings are new warnings. I'd not be tempted to fix URL constructor warning!

@iloveeclipse
iloveeclipse merged commit 9457da3 into eclipse-platform:master Oct 10, 2026
17 of 22 checks passed
@iloveeclipse
iloveeclipse deleted the java_25 branch October 10, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants