Trim detailed-diff highlight ending in trailing spaces - #2981
Open
tobiasmelcher wants to merge 1 commit into
Open
tobiasmelcher wants to merge 1 commit into
tobiasmelcher wants to merge 1 commit into
Conversation
This was referenced Sep 30, 2026
Contributor
vogella
approved these changes
Sep 30, 2026
The label is drawn with its trailing spaces stripped, so a detailed diff reaching into that region overshot the space-stripped labelLength and was dropped completely instead of being trimmed. The length is now clamped to labelLength via clampDetailedDiffLength, so the highlight is trimmed to the visible label. Reviewed with the help of Claude Code.
tobiasmelcher
force-pushed
the
d031119/fix-detailed-diff-trailing-space-clipping
branch
from
October 1, 2026 15:52
1140f0f to
c86669a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the trailing-spaces limitation noted by @vogella in review of #2965.
createDetailedDiffBackgroundRangescomputes itslabelLengthlimit withstripTrailing(), which removes trailing spaces. The old all-or-nothing bounds check (expandedStart + expandedLength <= labelLength) dropped a detailed-diff highlight completely when it reached into that stripped region — a detailed diff ending in trailing spaces lost its whole highlight instead of being trimmed.The length is now clamped to
labelLengthvia the sharedclampDetailedDiffLengthhelper, so the highlight is trimmed to the visible label, mirroring the trailing-newline fix from #2965.Reviewed with the help of Claude Code.