Skip to content

Dynamic Maximize/Minimize View label in context menu - #2970

Merged
elsazac merged 1 commit into
eclipse-platform:masterfrom
SougandhS:terminalMaximize
Sep 30, 2026
Merged

elsazac merged 1 commit into
eclipse-platform:masterfrom
SougandhS:terminalMaximize

Conversation

@SougandhS

Copy link
Copy Markdown
Contributor

Update the Terminal view context menu entry dynamically to display "Minimize View" when the view is maximized and "Maximize View" when the view is restored.

Before :
image

After :
image

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   55m 15s ⏱️ - 1m 6s
 4 844 tests ±0   4 822 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 423 runs  ±0  12 269 ✅ ±0  154 💤 ±0  0 ❌ ±0 

Results for commit cbd4bf7. ± Comparison against base commit 196685d.

♻️ This comment has been updated with latest results.

@SougandhS

Copy link
Copy Markdown
Contributor Author

Hi @laeubi, I hope this change is good to go

@SougandhS
SougandhS force-pushed the terminalMaximize branch 2 times, most recently from 965f1da to a6b346d Compare September 29, 2026 14:12

@laeubi laeubi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Update the Terminal view context menu entry dynamically to display
"Minimize View" when the view is maximized and "Maximize View" when the
view is restored.
@elsazac
elsazac merged commit aa5a77c into eclipse-platform:master Sep 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants