Remove unused options parameter from NativeHandler.putFileInfo - #2924
Draft
HannesWell wants to merge 1 commit into
Draft
Remove unused options parameter from NativeHandler.putFileInfo#2924HannesWell wants to merge 1 commit into
HannesWell wants to merge 1 commit into
Conversation
Contributor
HannesWell
commented
Sep 12, 2026
Comment on lines
613
to
619
| if ((options & EFS.SET_ATTRIBUTES) != 0) { | ||
| success &= LocalFileNativesManager.putFileInfo(filePath, info, options); | ||
| success &= LocalFileNativesManager.putFileInfo(filePath, info); | ||
| } | ||
| //native does not currently set last modified | ||
| if ((options & EFS.SET_LAST_MODIFIED) != 0) { | ||
| success &= file.setLastModified(info.getLastModified()); | ||
| } |
Member
Author
There was a problem hiding this comment.
Probably this change should be set on hold, because at least on Windows we could probably combine these two native calls into one and avoid the second one. In that case passing the options would be necessary again.
HannesWell
marked this pull request as draft
September 12, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.