Skip to content

Remove apache.aries.spifly and use the new equinox.spi in products - #4084

Merged
HannesWell merged 1 commit into
eclipse-platform:masterfrom
HannesWell:use-equinox.spi
Oct 8, 2026
Merged

HannesWell merged 1 commit into
eclipse-platform:masterfrom
HannesWell:use-equinox.spi

Conversation

@HannesWell

@HannesWell HannesWell commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Use the new org.eclipse.equinox.spi framework extension, that implements the OSGi Service Loader Mediator specification and was introduced in

The extension is already part of the o.e.equinox.core feature and doesn't need to be added explicitly.
Eventually it will not even be necessary to 'start/register' the extension in any way (i.e. adding it to the boot classpath via osgi.framework.extensions), once dynamic classloader-hook registration is supported:

Using it allows to remove org.apache.aries.spifly.dynamic.bundle.

Use the new org.eclipse.equinox.spi framework extension, that implements
the OSGi Service Loader Mediator specification.
The extension is already part of the o.e.equinox.core feature and
doesn't need to be added explicitly.

Using it allows to remove org.apache.aries.spifly.dynamic.bundle.
@HannesWell
HannesWell force-pushed the use-equinox.spi branch 2 times, most recently from 84d1f8e to 7e6a787 Compare October 8, 2026 22:33
@HannesWell
HannesWell merged commit 275ca1a into eclipse-platform:master Oct 8, 2026
6 checks passed
@HannesWell
HannesWell deleted the use-equinox.spi branch October 8, 2026 22:58
@iloveeclipse

Copy link
Copy Markdown
Member

Looks like the sources are missing, we see test fail:
https://download.eclipse.org/eclipse/downloads/drops4/I20261008-2300/testresults/html/org.eclipse.releng.tests_ep442I-unit-linux-x86_64-java25_linux.gtk.x86_64_25.html

Plugin directory missing required files: /home/jenkins/agent/workspace/automated-tests/ep442I-unit-linux-x86_64-java25/workarea/I20261008-2300/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.equinox.spi.source_1.0.0.v20261008-2211.jar;

java.lang.AssertionError: Plugin directory missing required files: /home/jenkins/agent/workspace/automated-tests/ep442I-unit-linux-x86_64-java25/workarea/I20261008-2300/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.equinox.spi.source_1.0.0.v20261008-2211.jar;
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.eclipse.releng.tests.BuildTests.testPluginFiles(BuildTests.java:182)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)

HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request Oct 9, 2026
The new equinox.spi Service Loader Mediator implementation does not
require service provider bundles to be started in order to consider
their provided services.

Follow-up to
- eclipse-platform#4084
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request Oct 10, 2026
The new equinox.spi Service Loader Mediator implementation does not
require service provider bundles to be started in order to consider
their provided services.

Follow-up to
- eclipse-platform#4084
HannesWell added a commit that referenced this pull request Oct 10, 2026
The new equinox.spi Service Loader Mediator implementation does not
require service provider bundles to be started in order to consider
their provided services.

Follow-up to
- #4084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants