Repository navigation
Upgrade JDT LS to 1.60.0 and lsp4j to 1.0.0 - #551
Merged
datho7561 merged 2 commits intoJul 31, 2026
Merged
Conversation
datho7561
requested changes
Jul 30, 2026
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Found one spot where you can avoid duplicating code, otherwise looking pretty good
MeherSru
marked this pull request as ready for review
July 31, 2026 13:47
datho7561
approved these changes
Jul 31, 2026
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good! There are some codelens related failures, but I think they're unrelated to this change, and this gets the project building again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates lsp4mp to use JDT LS 1.60.0 and lsp4j 1.0.0, as requested in #549. This also means Java 21 is now required (JDT LS 1.60 needs it).
Some code had to be updated because lsp4j 1.0.0 changed a few of its APIs.