Skip to content

Upgrade JDT LS to 1.60.0 and lsp4j to 1.0.0 - #551

Merged
datho7561 merged 2 commits into
eclipse-lsp4mp:masterfrom
MeherSru:upgrade-jdtls-160-lsp4j-100
Jul 31, 2026
Merged

datho7561 merged 2 commits into
eclipse-lsp4mp:masterfrom
MeherSru:upgrade-jdtls-160-lsp4j-100

Conversation

@MeherSru

Copy link
Copy Markdown
Contributor

Updates lsp4mp to use JDT LS 1.60.0 and lsp4j 1.0.0, as requested in #549. This also means Java 21 is now required (JDT LS 1.60 needs it).
Some code had to be updated because lsp4j 1.0.0 changed a few of its APIs.

@datho7561 datho7561 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one spot where you can avoid duplicating code, otherwise looking pretty good

@MeherSru
MeherSru marked this pull request as ready for review July 31, 2026 13:47

@datho7561 datho7561 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are some codelens related failures, but I think they're unrelated to this change, and this gets the project building again.

@datho7561
datho7561 merged commit 1c4feb9 into eclipse-lsp4mp:master Jul 31, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants