Repository navigation
Add xml/autoInsert endpoint with autoClose and autoQuote support - #1849
Merged
Merged
Conversation
angelozerr
force-pushed
the
feature/auto-insert
branch
3 times, most recently
from
September 12, 2026 17:21
472600c to
81147bb
Compare
angelozerr
marked this pull request as ready for review
September 12, 2026 17:26
Replace xml/closeTag with a new xml/autoInsert custom LSP request that supports two kinds of auto-insertion: - autoClose: auto-close tags when typing '>' or '/' (existing behavior) - autoQuote: auto-insert quotes after typing '=' for attribute values The xml/closeTag endpoint is kept deprecated for backward compatibility with Eclipse IDE. AutoCloseTagResponse is deprecated in favor of the new AutoInsertResponse class. Fixes eclipse-lemminx#1505, eclipse-lemminx#342 Signed-off-by: azerr <azerr@redhat.com>
angelozerr
force-pushed
the
feature/auto-insert
branch
from
September 14, 2026 13:17
81147bb to
4189ee5
Compare
datho7561
approved these changes
Sep 14, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Sorry, finished reviewing this a while ago then got distracted by vscode-javals. Still need to look through the client side though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
xml/closeTagwith a newxml/autoInsertcustom LSP request that supports two kinds of auto-insertion:>or/, and when removing/from a self-closing tag (AutoOpen closed Tags #1505)=for attribute values (After an attribute, automatically insert quotes when typing=#342)The xml/closeTag endpoint is kept deprecated for backward compatibility with Eclipse IDE. AutoCloseTagResponse is deprecated in favor of the new AutoInsertResponse class.
Fixes #1505, #342
Here the vscode-xml PR redhat-developer/vscode-xml#1170
Here a demo: