Refine CSR matrix unary and sym methods - #339
Merged
Merged
Conversation
Fix the `BaseType` import typo in `CSRMatrix_SetMethods` and clean up CSR matrix unary/symmetry code to use explicit module imports, aliased procedure calls, and normalized math/default constants. The changes also tighten symmetric CSR sparsity construction by switching to named `GetNNZ` arguments, adding the missing utility imports, and improving consistency in error handling and procedure naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
BaseTypeimport typo inCSRMatrix_SetMethodsand clean up CSR matrix unary/symmetry code to use explicit module imports, aliased procedure calls, and normalized math/default constants. The changes also tighten symmetric CSR sparsity construction by switching to namedGetNNZarguments, adding the missing utility imports, and improving consistency in error handling and procedure naming.