Skip to content

Add Japanese translation - #306

Open
Kamesuta wants to merge 4 commits into
dscalzi:masterfrom
Kamesuta:feature/japanese
Open

Kamesuta wants to merge 4 commits into
dscalzi:masterfrom
Kamesuta:feature/japanese

Conversation

@Kamesuta

@Kamesuta Kamesuta commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Changes

  • Added Japanese translation for the launcher interface
  • Fixed CSS to prevent Japanese text from breaking in the middle of a word

@dscalzi

dscalzi commented Oct 7, 2023

Copy link
Copy Markdown
Owner

My only concern is how do we keep these up to date?

@GeekCornerGH

Copy link
Copy Markdown
Contributor

My only concern is how do we keep these up to date?

@dscalzi Fallback to english when some translations are missing

@xllifi

xllifi commented Oct 12, 2023

Copy link
Copy Markdown

My only concern is how do we keep these up to date?

more like why

this launcher is not meant to be used stock
you edit something anyway, so making a custom translation shouldn't be a problem

Comment thread app/assets/lang/ja_JP.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants