Repository navigation
Revert "Revert "Run CoreCLR microbenchmarks on macOS 26 Arm64 M4"" - #5329
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The required runtime artifact dependency is not merged, and the release-branch guard misses exact release refs.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Re-enables CoreCLR microbenchmarks on macOS 26 Arm64 M4 and canonicalizes project paths.
Changes:
- Adds the enabled-by-default M4 pipeline job.
- Resolves project paths through symlinks.
- Tests canonical restore/build paths.
| File | Description |
|---|---|
eng/pipelines/runtime-perf-jobs.yml |
Adds the M4 benchmark configuration and job. |
scripts/dotnet.py |
Canonicalizes project and working-directory paths. |
scripts/tests/test_dotnet.py |
Tests direct and symlinked project paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: m4Micro | ||
| type: object | ||
| default: | ||
| enabled: true |
| ${{ parameter.key }}: ${{ parameter.value }} | ||
|
|
||
| # CoreCLR Mac M4 microbenchmarks. Older runtime branches do not build macOS Arm64 artifacts. | ||
| - ${{ if and(eq(parameters.m4Micro.enabled, true), not(or(startswith(variables['Build.SourceBranch'], 'refs/heads/release/'), startswith(variables['Build.SourceBranch'], 'refs/heads/internal/release/')))) }}: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5328