HttpRouteFormatter - Log redaction leaks replayable bearer token #7826

using Microsoft.Extensions.Compliance.Classification;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Http.Diagnostics;
using Microsoft.Extensions.Http.Logging;
using Microsoft.Extensions.Logging;

var services = new ServiceCollection()
    .AddLogging(b => b.AddJsonConsole())
    .AddFakeRedaction(o => o.RedactionFormat = "[REDACTED]");

foreach (var mode in new[] { OutgoingPathLoggingMode.Formatted, OutgoingPathLoggingMode.Structured })
{
    services.AddHttpClient(mode.ToString())
        .ConfigurePrimaryHttpMessageHandler(() => new OkHandler())
        .AddExtendedHttpClientLogging(o =>
        {
            o.RequestPathLoggingMode = mode;
            o.RouteParameterDataClasses["token"] = new DataClassification("Demo", "Secret");
            o.RouteParameterDataClasses["format"] = DataClassification.None;
        });
}

using (var provider = services.BuildServiceProvider())
{
    var factory = provider.GetRequiredService<IHttpClientFactory>();
    await SendAsync(factory.CreateClient("Formatted"), "/a/{token}.{format}", "/a/part1.part2.part3.json");
    await SendAsync(factory.CreateClient("Structured"), "/b/{format}.{token}", "/b/json.secret");
}

static async Task SendAsync(HttpClient client, string route, string path)
{
    using var request = new HttpRequestMessage(HttpMethod.Get, "http://localhost" + path);
    request.SetRequestMetadata(new RequestMetadata { RequestRoute = route });
    using var response = await client.SendAsync(request);
}

sealed class OkHandler : HttpMessageHandler
{
    protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
        => Task.FromResult(new HttpResponseMessage(System.Net.HttpStatusCode.OK));
}