Skip to content

Preserve subquery input expressions in EXPLAIN queries - #500

Merged
nicktobey merged 2 commits into
mainfrom
nicktobey/explain
Oct 7, 2026
Merged

nicktobey merged 2 commits into
mainfrom
nicktobey/explain

Conversation

@nicktobey

Copy link
Copy Markdown

Previously, because Explain parse nodes did not implement WalkableSQLNode, Vitess would not walk them to populate input expressions on subqueries. This let to cases where go-mysql-server would produce a different plan for a DESCRIBE PLAN query compared to the original query.

@nicktobey
nicktobey requested a review from zachmu as a code owner October 7, 2026 22:14

@elianddb elianddb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicktobey
nicktobey merged commit 441dd42 into main Oct 7, 2026
4 checks passed
@nicktobey
nicktobey deleted the nicktobey/explain branch October 7, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants