[reltuk]

Moves from early return to Skip() in a number of places.

Removes some double-nesting subtests.

Removes some accidental parent-test Skips().

Fixes some unused or unsupported things in a few subtests, like skip-before-analyze in plan tests and
stop-trying-to-Kill()-in-tests-without-a-processlist.

[itoqa]

Commit: 1816c4a: 18 test cases ran, 18 passed ✅.

Summary

Coverage spans normal query and join behavior, query planning, setup and assertion ordering, result isolation after conversion errors, iterator cleanup after panics, index handling, prepared-query skips, and unsupported-feature visibility. These checks exercise both happy paths and edge cases around failures, cleanup, ordering, and state reuse, with healthy results overall.

Safe to merge — no regressions, new failures, or previously flagged failures attributable to this PR were found, and the exercised application behaviors remain healthy. No merge-blocking issue is present; unrelated environment limitations are not evidence of a product defect.

Tests run by Ito

Result	Severity	Type	Description
✅	—	General	Join checks returned the expected rows, drained all results, cleared temporary memory, and left the engine ready for the next join case.
✅	—	General	The available conversion and SQL logic tests passed, and the query adapter returns empty schema and result values when row conversion fails. Direct browser verification was blocked because this Go test repository has no usable local browser service or dedicated fixture.
✅	—	General	A setup error is reported before later checks run, so assertions cannot succeed against incomplete test data.
✅	—	General	The query and conversion test suites passed, showing that a failed conversion does not leave partial results behind or disturb the next query.
✅	—	Costers	All six join coster variants ran once and passed in deterministic lexicographic order.
✅	—	Indexes	Setup skipped ordinary, UNIQUE, FULLTEXT, SPATIAL, and VECTOR index statements, then continued and created the tables around them.
✅	—	Indexes	A setup statement with the words CREATE INDEX inside a quoted value was treated as a normal statement and executed.
✅	—	Iterators	The memory query runner closes its iterator, passes the original panic onward, and remains usable for later queries.
✅	—	Joinchecks	The join suite completed successfully. It drained the query rows, checked the expected results, confirmed that memory caches were empty, and validated the engine.
✅	—	Joinorder	The join-order check ran and passed even when the matching correctness check was skipped.
✅	—	Plans	The repository code keeps ordinary query checks running and shows unsupported plan checks as named skipped subtests on server-backed engines. The server setup was unavailable in this run, but the local query-plan suite passed and the production test harness contains the expected server-specific behavior.
✅	—	Plans	The local engine inspected and matched the expected query plans. The full query-plan script test passed.
✅	—	Queries	Fixture setup completed before the normal query checks, and the expected rows and columns were validated successfully.
✅	—	Rev	The prepared query suite passed. Cases marked to skip in prepared mode appeared once as named skipped subtests, and no skipped query produced a query assertion failure.
✅	—	Rev	The join planning suite passed. The join case marked to skip appeared once as a named skipped subtest, and its query was not executed.
✅	—	Rev	The memory SQL test suite passed. It preserved the schema and flattened row values, returned iterator errors, and allowed later queries to continue after panic handling.
✅	—	Rev	The on-update test completed successfully. Scripts with no listed assertions still ran their fallback query, and each assertion was handled in its own named subtest.
✅	—	Skipped	Queries that need keyless tables remain listed by their original names and are skipped with the reason that the harness does not support keyless tables.

Tip

Reply with @itoqa to send us feedback on this test run.