FIX: Ensure Redis log directory is created - #1110
Merged
Merged
Conversation
We can safely omit Postgres log directories in /var/log, but /var/log/redis needs to exist for certain tests in discourse/discourse to succeed.
nattsw
approved these changes
Aug 11, 2026
nattsw
left a comment
nattsw
left a comment
Contributor
There was a problem hiding this comment.
I must be blind but I don't see where the directory is gettin gcreated
Contributor
Author
|
The It would have been written like that because we don't care about Postgres cruft in /var/log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/var/log/redis needs to exist for certain tests in discourse/discourse to succeed. We were piggybacking off the Postgres install which discards the contents of /var/log via a tmpfs.