fix: treat terragrunt run --all plan as hasPlanStep to skip single-file terraform show - #2655
Open
ramkalapala wants to merge 1 commit into
Open
ramkalapala wants to merge 1 commit into
ramkalapala wants to merge 1 commit into
Conversation
…le terraform show
Author
|
Hi team, raised this PR to address #2552, @s1ntaxe770r, would really appreciate a review and approval when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2552
Problem
When using
terragrunt run --all planvia a customrunstep in theworkflow,
driftctl scancompletes successfully but then fails with:error running terraform show: exit status 1
Root Cause
hasPlanStepinlibs/execution/execution.gois only set totruewhen a step has
action == "plan":With a custom
runstep,hasPlanStepstaysfalse. After the runstep completes successfully, Digger falls into the
!hasPlanStepbranchand calls
terraform showagainstLocalPlanFilePath()— expecting asingle
.tfplanfile. Butterragrunt run --all planwrites per-moduleplan files across subdirectories, not a single file at that path.
Fix
Extend the
hasPlanStepcheck to also treatrunsteps containingrun --all planas a plan step, skipping the single-fileterraform showpost-processing:No new imports required —
stringsis already imported.Testing
Existing test suite unchanged. Fix only affects workflows using
terragrunt run --all planvia a customrunstep.