Skip to content

fix: remove web middleware from github setup and exchange-code routes #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaylenmistry wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: remove web middleware from github setup and exchange-code routes #2631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions backend/bootstrap/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,12 @@ func Bootstrap(templates embed.FS, diggerController controllers.DiggerController

githubGroup := r.Group("/github")
githubGroup.Use(middleware.GetWebMiddleware())
// authless endpoint because we no longer rely on orgId
// Auth for these endpoints is handled by the UI layer before proxying, so
// they do not require the backend web middleware.
r.GET("/github/callback", diggerController.GithubAppCallbackPage)
r.GET("/github/setup", controllers.GithubAppSetup)
r.GET("/github/exchange-code", diggerController.GithubSetupExchangeCode)
githubGroup.GET("/repos", diggerController.GithubReposPage)
githubGroup.GET("/setup", controllers.GithubAppSetup)
githubGroup.GET("/exchange-code", diggerController.GithubSetupExchangeCode)

publicPrefix := utils.NormalizePublicPathPrefix(os.Getenv("DIGGER_PUBLIC_PATH_PREFIX"))
if publicPrefix != "" {
Expand All @@ -185,9 +186,9 @@ func Bootstrap(templates embed.FS, diggerController controllers.DiggerController
prefixedGithubGroup := prefixed.Group("/github")
prefixedGithubGroup.Use(middleware.GetWebMiddleware())
prefixed.GET("/github/callback", diggerController.GithubAppCallbackPage)
prefixed.GET("/github/setup", controllers.GithubAppSetup)
prefixed.GET("/github/exchange-code", diggerController.GithubSetupExchangeCode)
prefixedGithubGroup.GET("/repos", diggerController.GithubReposPage)
prefixedGithubGroup.GET("/setup", controllers.GithubAppSetup)
prefixedGithubGroup.GET("/exchange-code", diggerController.GithubSetupExchangeCode)
}

authorized := r.Group("/")
Expand Down