lopper: assists: zephyr: Ensure nodes are proper for versal R5 zephyr-helloworld build - #793
Merged
zeddii merged 1 commit intoJul 28, 2026
Conversation
Collaborator
Author
|
@kedareswararao please review this is needed for versal R5 Yocto SDT multiconfig target to build (both for configure step and compile step) |
| node.add(node["#size-cells"]) | ||
|
|
||
| node["clock-frequency"] = LopperProp("clock-frequency") | ||
| node["clock-frequency"].value = node["xlnx,clock-freq"].value |
Contributor
There was a problem hiding this comment.
what if this property xlnx,clock-freq is not present in the node? please check for the existence of the property and default value in case if its absent
…-helloworld build SPI node needs right clock-frequency per inherited binding of https://docs.zephyrproject.org/latest/build/dts/api/bindings/flash_controller/cdns%2Cqspi-nor.html Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
bentheredonethat
force-pushed
the
zephyr-r5-versal-fix-july27-2026
branch
from
July 28, 2026 14:20
eb3d29e to
70d820c
Compare
Collaborator
Author
|
@kedareswararao addressed |
kedareswararao
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPI node needs right clock-frequency per inherited binding of https://docs.zephyrproject.org/latest/build/dts/api/bindings/flash_controller/cdns%2Cqspi-nor.html