Skip to content

fix(dq-element): remove memoize wrapper around constructor - #5303

Open
shoaibyazdani wants to merge 1 commit into
dequelabs:developfrom
shoaibyazdani:fix/remove-dqelement-memoize
Open

fix(dq-element): remove memoize wrapper around constructor#5303
shoaibyazdani wants to merge 1 commit into
dequelabs:developfrom
shoaibyazdani:fix/remove-dqelement-memoize

Conversation

@shoaibyazdani

@shoaibyazdani shoaibyazdani commented Aug 10, 2026

Copy link
Copy Markdown

Closes #5298

What

Removes the memoize wrapper around the DqElement constructor.

Why

Closes #5298. The memoize wrapper was hurting performance and adding ~20s to reporter initialization. Each new DqElement call had to unwrap the memoize wrapper, which is more expensive than direct instantiation.

Changes

  • Removed import memoize from './memoize'; from lib/core/utils/dq-element.js
  • Changed const DqElement = memoize(function DqElementMemoized(...)) to const DqElement = function DqElement(...)
  • Renamed inner function name to match the variable
  • 1 file changed, 2 insertions(+), 3 deletions(-)

Closes:

@shoaibyazdani
shoaibyazdani requested a review from a team as a code owner August 10, 2026 04:31
@CLAassistant

CLAassistant commented Aug 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@shoaibyazdani
shoaibyazdani force-pushed the fix/remove-dqelement-memoize branch from eb5ea79 to 7fb065c Compare August 10, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove memoize of DqElement

2 participants