Repository navigation
feat: reply with usage instead of raising on command syntax errors - #46
Merged
Merged
Conversation
Exceptions from malformed commands (e.g. /set_name with no name) used to propagate to the crew-wide exception notifier, paging the crew for what's really just a user typo. Add targeted handling so the sender gets an inline usage reply instead, while unrelated bugs still reach the crew. Rewrote command dispatch in relay.py from chained if checks to match/case. Most commands can now catch argument errors by shape, new_message gets a try/except check. Generally preserved behavior, with the exception of "/set_name " or "/set_outside_help " (trailing whitespace) that allowed to silently set an empty name/help text. tests/test_bot.py: add test_command_syntax_errors covering /set_name, /new_message, and /add_contact syntax errors, and confirm the bot keeps handling messages normally afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions from malformed commands (e.g. /set_name with no name) used to propagate to the crew-wide exception notifier, paging the crew for what's really just a user typo. Add targeted handling so the sender gets an inline usage reply instead, while unrelated bugs still reach the crew.
Rewrote command dispatch in relay.py from chained if checks to match/case. Most commands can now catch argument errors by shape, new_message gets a try/except check.
Generally preserved behavior, with the exception of "/set_name " or "/set_outside_help " (trailing whitespace) that allowed to silently set an empty name/help text.
tests/test_bot.py: add test_command_syntax_errors covering /set_name, /new_message, and /add_contact syntax errors, and confirm the bot keeps handling messages normally afterward.