Skip to content

feat(pyinfra): only run enable-linger when necessary - #45

Merged
missytake merged 2 commits into
mainfrom
pyinfra-enable-linger-idempotent
Aug 13, 2026
Merged

missytake merged 2 commits into
mainfrom
pyinfra-enable-linger-idempotent

Conversation

@missytake

Copy link
Copy Markdown
Contributor

Needs to be tested next time we deploy a new team-bot.

@j4n j4n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though I dont really know why that change was necessary. More idempotent that way?

@missytake

missytake commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor Author

More idempotent that way?

exactly, right now it always shows "Success" even if nothing changed.

If it works here, we can also use it in other areas of our infra.

@missytake

Copy link
Copy Markdown
Contributor Author

This is actually better: https://github.com/deltachat/sysadmin/pull/296/changes#diff-965326020811eeaf0f949b025c8f867d22284e20db13c3fe68df2252eb6b8311

@missytake
missytake force-pushed the pyinfra-enable-linger-idempotent branch from a75abc0 to 9323795 Compare August 13, 2026 11:12
@missytake
missytake requested a review from j4n August 13, 2026 11:12
@missytake missytake changed the title feat: make enable-linger pyinfra operation declarative feat(pyinfra): only run enable-linger when necessary Aug 13, 2026

@j4n j4n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good pattern!

@missytake
missytake merged commit 1e21d78 into main Aug 13, 2026
3 checks passed
@missytake
missytake deleted the pyinfra-enable-linger-idempotent branch August 13, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants