Repository navigation
feat: add ExceptionNotifier to notify crew about exceptions - #43
Merged
Merged
Conversation
j4n
force-pushed
the
j4n/exception-notifier
branch
2 times, most recently
from
July 27, 2026 13:47
e33c68a to
2e3c530
Compare
Contributor
Author
|
Also lowered required Python to 3.10; and maybe uv.lock shouldn't be in the repo? |
j4n
force-pushed
the
j4n/exception-notifier
branch
3 times, most recently
from
July 28, 2026 09:42
8492bfa to
29f4419
Compare
missytake
approved these changes
Jul 29, 2026
missytake
left a comment
missytake
left a comment
Contributor
There was a problem hiding this comment.
Love it! the details in the html is a nice touch. 3 minor comments:
j4n
force-pushed
the
j4n/exception-notifier
branch
from
July 29, 2026 16:45
29f4419 to
ee4250d
Compare
3.11 does not seem to be needed, drop required Python version to 3.10 and add to the test matrix, amend pyproject.toml to make argparse happy.
Closes Issue #42: "team-bot hook exceptions are silent to the team" The deltachat-rpc-client event loop already catches hook exceptions and logs them to the journal. Here, we add a decorator that catches the exceptions and forwards them to the crew chat. Tries to avoid flooding with a simple cooldown timer (1h by default). The exception is sent as an HTML message with a one-line summary and a <pre>-wrapped traceback. The decorator sits below @relayhooks.on() to register the wrapper. Add tests for html format and an end-to-end test.
uv.lock churns on every dependency resolution and merges poorly between contributors on different platforms/python versions; drop it from version control and ignore it going forward.
j4n
force-pushed
the
j4n/exception-notifier
branch
from
July 29, 2026 18:08
ee4250d to
79e8fb9
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #42: team-bot hook exceptions are silent to the team. The deltachat-rpc-client event loop already catches hook exceptions and logs them to the journal. Here, we add a decorator that catches the exceptions and forwards them to the crew chat. Tries to avoid flooding with a simple cooldown timer (5 min by default). The exception is sent as an HTML message with a one-line summary and a pre-wrapped traceback. The decorator sits below @relayhooks.on(...) on each hook so the hook collection registers the wrapper, not the bare function. Add tests for html format and an end-to-end test.