Skip to content

IMPORT ERROR: when you select a control id with empty fields it does not populate actually import the sheet to start creating mappings #229

Description

@cmwylie19

Describe what should be investigated or refactored

when you select a control id with empty fields it does not populate actually import the sheet to start creating mappings. We need to at least warn the user as of why the sheet cannot be imported

[0] [DEBUG] Justification fields received: []
[0] [DEBUG] Import parameters received: {
[0]   controlIdField: "(Starting) Row in Someone's Spreadsheet",
[0]   startRow: '1',
[0]   controlSetName: 'Control Test Results (eMASS Ready)',
[0]   controlSetDescription: 'Imported from Control Test Results (eMASS Ready).xlsx'
[0] }
[0] [DEBUG] Headers found: [
[0]   'Control',
[0]   "How it's Satisfied",
[0]   "(Starting) Row in Someone's Spreadsheet"
[0] ]
[0] [DEBUG] After conversion, looking for control ID field: -starting-row-in-toby-s-spreadsheet
[0] Error processing spreadsheet: TypeError: controlId.trim is not a function
[0]     at extractFamilyFromControlId (/Users/someone/defenseunicorns/lula/cli/server/spreadsheetRoutes.ts:784:24)
[0]     at processSpreadsheetData (/Users/someone/defenseunicorns/lula/cli/server/spreadsheetRoutes.ts:368:19)
[0]     at <anonymous> (/Users/someone/defenseunicorns/lula/cli/server/spreadsheetRoutes.ts:228:25)
[0]     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Links to any relevant code

spreadsheetRoutes

Additional context

We need some notifications most likely

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions