Fix(io): improve module_hs sparse matrix output safety#7465
Closed
goodchong wants to merge 8 commits into
Closed
Conversation
Add a Phase 0 compatibility test suite for write_HS_R-related output contracts and save the refactor plan. Tests: ctest --test-dir build-phase0 -R MODULE_IO_write_hs_r_compat_test -V
Fix sparse binary header writing, non-MPI save_mat stream opening, Vxc(R) ownership, and AngularMomentumCalculator null logging. Extend write_HS_R compatibility coverage for legacy binary sparse headers and update the refactor plan with Phase 1 status. Tests: ctest --test-dir build-phase0 -R MODULE_IO_write_hs_r_compat_test -V Tests: ctest --test-dir build-phase0 -R MODULE_IO_cal_pLpR_test -V Tests: ctest --test-dir build-phase0 -R MODULE_IO_single_R_test -V Tests: ctest --test-dir build-phase0 -R MODULE_IO_sparse_matrix_test -V Builds: cmake --build build-phase0 --target io_advanced -j8 Builds: cmake -B build-phase1-nompi -DBUILD_TESTING=OFF -DENABLE_MPI=OFF && cmake --build build-phase1-nompi --target io_advanced -j8
Keep the local markdown file untracked while removing it from the remote branch contents.
mohanchen
reviewed
Jun 12, 2026
| if (binary) { | ||
| int nlocal = PARAM.globalv.nlocal; | ||
| const int step = std::max(istep, 0); | ||
| const int nlocal = PARAM.globalv.nlocal; |
Collaborator
There was a problem hiding this comment.
This parameter can be passed into the function instead of using a global variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #...
Unit Tests and/or Case Tests for my changes
What's changed?
Summary
Tests
Any changes of core modules? (ignore if not applicable)