Skip to content

fix(hostname): don't allow machine tags to begin/end with '-' or '.'#60

Open
deepin-ci-robot wants to merge 1 commit into
deepin-community:masterfrom
deepin-ci-robot:backport/fix-hostname-machine-tag-chars
Open

fix(hostname): don't allow machine tags to begin/end with '-' or '.'#60
deepin-ci-robot wants to merge 1 commit into
deepin-community:masterfrom
deepin-ci-robot:backport/fix-hostname-machine-tag-chars

Conversation

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Summary

Backport upstream commit 95c7dc33087ae99db8ab8b6614550541a8e7187f which adds validation to reject machine tags that begin or end with '-' or '.' characters. This is load-bearing since '+/-' are used as prefix for adding/removing tags from the list.

Note: The machine_tag_is_valid function was introduced in a newer upstream version not present in this codebase, so the patch also includes the function definition with the fix already applied.

Changes

  • Add debian/patches/fix-hostname-machine-tag-chars.patch
  • Modify debian/patches/series
  • Modify debian/changelog

Upstream

systemd/systemd@95c7dc33

Generated-By: glm-5-turbo
Co-Authored-By: deepin-ci-robot packages@deepin.org

hostname-util: don'"'"'t allow machine tags to begin/end with '-' or '.'

Don'"'"'t allow "-" and "." as first or last char. (This is load-bearing,
we want that "+"/"-" can be used as prefix for adding/removing tags from
the list).

Changes:
  - Add debian/patches/fix-hostname-machine-tag-chars.patch
  - Modify debian/patches/series
  - Modify debian/changelog

Upstream: systemd/systemd@95c7dc3

Generated-By: glm-5-turbo
Co-Authored-By: deepin-ci-robot <packages@deepin.org>
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 255.2-4deepin31
EXISTED: no
DISTRIBUTION: unstable

@deepin-community-ci-bot

Copy link
Copy Markdown

TAG Bot

New tag: 255.2-4deepin32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #63

@deepin-community-ci-bot

Copy link
Copy Markdown

TAG Bot

New tag: 255.2-4deepin33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #64

@deepin-community-ci-bot

Copy link
Copy Markdown

TAG Bot

New tag: 255.2-4deepin34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #65

@deepin-community-ci-bot

Copy link
Copy Markdown

TAG Bot

New tag: 255.2-4deepin35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #66

@deepin-community-ci-bot

Copy link
Copy Markdown

TAG Bot

New tag: 255.2-4deepin36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants