Repository navigation
fix: run Trivy misconfiguration scanning by setting scan.scanners - #199
Merged
Merged
Conversation
github-actions
Bot
added
patch
Contributor
Trivy Security Scan ResultsNote This PR introduces no new findings. Scan performed by Trivy v0.69.3 |
Contributor
|
🎉 This PR is included in version 1.32.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the inline
trivy.yamloftrivy-scan.yaml,scannerssat at the top level, where Trivy ignores it. It only readsscan.scanners. Trivy therefore ran its default scanners (vuln, secret) and misconfiguration scanning never ran. This movesscanners: [vuln, secret, misconfig]underscan:. Nothing else changes (severity, scanner list and the #198 PR diff logic are untouched).Proof (Trivy 0.69.3, the workflow's default)
A Dockerfile without
USER, scanned with the config extracted from the workflow before and after the change:[misconfig]log linescanners)scan.scanners)Misconfiguration scanning is enabledDS-0002Impact on default branches
Pushes to the default branch fail on every finding, so enabling misconfig can turn main red. I scanned
git archive origin/mainof each repo underprojects/with the fixed config and each repo's own.trivyignore, read-only.required-trivyapplies to the default branch org-wide, so I treated every repo there as covered. The localorigin/mainrefs were not fetched, so they may lag the remote.Vet.Salopes also has 11 vulnerability findings that already fail it today, with or without this change. No repo has secret findings.
Merging this will turn main red in the 6 repos with findings until they fix or ignore them. PRs are unaffected for existing findings, because #198 fails them only on findings the PR introduces.
Commit type
fix:(patch). It repairs behavior #198 meant to ship, and no consumer input, output or interface changes. semantic-release movesv1on merge, so the new scanning reachesrequired-trivyright away. If that is too disruptive, hold the merge until the repos above are triaged.