[improve][pip] AS-5322: alpine-migration-pulsar-image-3-1 - #759
Open
hshankar31 wants to merge 4 commits into
Open
[improve][pip] AS-5322: alpine-migration-pulsar-image-3-1#759hshankar31 wants to merge 4 commits into
hshankar31 wants to merge 4 commits into
Conversation
hshankar31
changed the title
hshankar31
changed the title
sandeep-ctds
left a comment
sandeep-ctds
left a comment
Collaborator
There was a problem hiding this comment.
Did we follow OSS changes for alpine for this? Can you give a summary of additional changes made other than OSS in the description?
|
|
||
| ################################################ | ||
| ## Build the APK package | ||
| FROM alpine:3.19 as apk |
Collaborator
There was a problem hiding this comment.
Why are we uniquely using apline:3.19 here, when the rest of them are using 3.21?
| ENV JAVA_HOME=/opt/jvm | ||
|
|
||
| # Copy Python dependencies from the other stage | ||
| COPY --from=python-deps /usr/lib/python3.12/site-packages /usr/lib/python3.12/site-packages |
Collaborator
There was a problem hiding this comment.
How are we sure it will be python3.12?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes